tunnel interface names cannot be longer than 15 characters #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, if I had used a private IPs (10.X.X.X) I probably wouldn't have run into this issue. However, this is an edge case that other uses may run into. |
|
@andrewsykim problem may arise with private ip range of 172.16..-172.31.. as well. So it must be fixed. But i know some production users who are using old convention. Modifing the logic to generate the tunnel interface name with your change only if length of IP address without |
|
@murali-reddy that's a great idea, I'll update the PR soon! |
andrewsykim
force-pushed
the
andrewsykim/273
branch
from
641bf63
to
33c00d5
Compare
|
updated |
|
Thanks @andrewsykim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some strange behaviour as reported here. Turns out it was because linux interface names cannot be more than 15 characters. Removing the
-in the interface name ensures that we will always have at most 15 characters for IPv4. However, I do have concerns around backwards compatibility and some more work may have to be done here so that the transition is smoother. @murali-reddy would love your thoughts here.