Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add service/endpoint event handler for routes controller #384

Merged
merged 1 commit into from
Apr 11, 2018
Merged

add service/endpoint event handler for routes controller #384

merged 1 commit into from
Apr 11, 2018

Conversation

andrewsykim
Copy link
Collaborator

No description provided.

@andrewsykim andrewsykim force-pushed the routes-informer branch 4 times, most recently from 2480759 to e6709c5 Compare April 11, 2018 16:26
@murali-reddy
Copy link
Member

murali-reddy commented Apr 11, 2018 •
edited
Loading

Overall changes look good. Please consider below change in this PR.

Its ambiguous to use advertiseIPs, withdrawIPs, bgpAdvertiseIP etc. Since kube-router also advertising the pod CIDR's from the same module, i suggest names like below, so the intent is more explicit.

  • advertiseServiceVips()
  • withdrawServiceVips()
  • bgpAdvertiseServiceVip()

A general comment from this PR and #373. I have opened #386 . No need to block this PR on #386.

I belive we need to sort out both #386 and #380, after the number of refactors that went in lately.

@andrewsykim andrewsykim force-pushed the routes-informer branch 2 times, most recently from 2e1c9fc to 9c21d4d Compare April 11, 2018 17:47
@andrewsykim
Copy link
Collaborator Author

@murali-reddy used advertiseVIPs and withdrawVIPs since it's also external/LB IPs, PTAL

@murali-reddy
Copy link
Member

Thanks @andrewsykim LGTM

@andrewsykim andrewsykim merged commit ab08c31 into cloudnativelabs:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewsykim @murali-reddy