Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes regression in BGP route reflector functionality. #573

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Conversation

murali-reddy
Copy link
Member

@murali-reddy murali-reddy commented Nov 14, 2018

Use proper conversion so correct cluster ID is passed to GoBGP library. GoBGP was complaining:

E1114 19:05:19.722793       1 bgp_peers.go:146] Failed to add node 192.168.56.101 as peer due to route-reflector-cluster-id should be specified as IPv4 address or 32-bit unsigned integer
E1114 19:05:19.723448       1 bgp_peers.go:146] Failed to add node 192.168.56.102 as peer due to route-reflector-cluster-id should be specified as IPv4 address or 32-bit unsigned integer

with out this fix as kube-router was passing wrong cluster-id.

Please use cloudnativelabs/kube-router-git:rr-fix if you would like to test.

Use proper conversion so correct cluster ID is passed to GoBGP library
@murali-reddy
Copy link
Member Author

Merging based on the user confirmation that functionality works.

https://kubernetes.slack.com/archives/C8DCQGTSB/p1540402541000100

@murali-reddy murali-reddy merged commit 4d6b7fa into master Nov 15, 2018
@murali-reddy murali-reddy deleted the rr-fix branch December 26, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant