Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement per-service annotations to control IP advertisment #575

Merged
merged 7 commits into from
Dec 9, 2018

Conversation

asteven
Copy link
Contributor

@asteven asteven commented Nov 15, 2018

Fixes #75.

Please let me know if I did something obviously wrong or if there are better/nicer ways to code this.
This is the first go code I ever wrote, I'm a Python programmer at heart.

@murali-reddy
Copy link
Member

thanks for the PR @asteven Nice job for first go code :)

Service type in the annotations

  • kube-router.io/service.advertise.cluster
  • kube-router.io/service.advertise.external
  • kube-router.io/service.advertise.loadbalancer

does not sound complete. Can we make it to

  • kube-router.io/service.advertise.clusterip
  • kube-router.io/service.advertise.externalip
  • kube-router.io/service.advertise.loadbalancerip

Signed-off-by: Steven Armstrong <[email protected]>
Signed-off-by: Steven Armstrong <[email protected]>
@asteven
Copy link
Contributor Author

asteven commented Nov 16, 2018

thanks for the PR @asteven Nice job for first go code :)

Thanks ;-)

Service type in the annotations

* `kube-router.io/service.advertise.cluster`

* `kube-router.io/service.advertise.external`

* `kube-router.io/service.advertise.loadbalancer`

does not sound complete. Can we make it to

* `kube-router.io/service.advertise.clusterip`

* `kube-router.io/service.advertise.externalip`

* `kube-router.io/service.advertise.loadbalancerip`

Done.

@murali-reddy murali-reddy merged commit 1a30f9e into cloudnativelabs:master Dec 9, 2018
@murali-reddy
Copy link
Member

Thanks @asteven

@asteven asteven deleted the issue/75 branch December 21, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants