First stab at pushing multiarch releases #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @wilmardo I can not test it now. If i face an issue during release will address issues if any at that point. |
ticpu
pushed a commit
to ticpu/kube-router
that referenced
this pull request
Dec 10, 2019
mk01
pushed a commit
to mk01/kube-router-ipv6
that referenced
this pull request
Mar 12, 2020
(cherry picked from commit 4be51ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #622 #591
I tried to understand the build and push process and adapted it so it should push and build multiarch.
Added the
push-manifestin the makefile, it uses the estesp/manifest-tool to push the manifest for the release and latest tag.It should work but I haven't test it :)