Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Don't ignore silently service proxy errors. #796

Merged

Conversation

nerzhul
Copy link
Contributor

@nerzhul nerzhul commented Oct 15, 2019

Currently we can have error on service proxy if we cannot set sysctl (in my case), but those errors are return and not shown. Just show them, like other controllers.

I found this error by running service proxy as daemonset like we did for the network part. It's very annoying to have a silent fail on that part. Instead continue because we can set sysctl on the host part directly

Currently we can have error on service proxy if we cannot set sysctl (in my case), but those errors are return and not shown. Just show them, like other controllers
@murali-reddy
Copy link
Member

Thanks @nerzhul for the PR.

While glog.Errorf at-least logs the error to give indication, but ideally it should be glog.Fatalf as we should not progress further at least where its fatal. Perhaps that can be addressed in a separate PR.

@murali-reddy murali-reddy merged commit c160e90 into cloudnativelabs:master Dec 13, 2019
@nerzhul nerzhul deleted the fix/silent_sysctl_errors branch December 13, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants