Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kiam version upgrade to version that supports IMDS v2 #235

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Kiam version upgrade to version that supports IMDS v2 #235

merged 1 commit into from
Apr 22, 2020

Conversation

3h4x
Copy link
Contributor

@3h4x 3h4x commented Apr 22, 2020

what

  1. [kiam] Kiam 3.6-rc1 accepts by default requests to IMDSv2

why

  1. New versions of AWS SDK can use IMDSv2 which is blocked prior to kiam 3.6-rc0 version. This creates a lot of alarms based on kiam_metadata_proxy_requests_blocked_total which are false positives as clients can fallback to IMDSv1.

Ref:

@3h4x 3h4x requested review from goruha, maximmi, osterman, a team and aknysh April 22, 2020 18:32
@3h4x 3h4x merged commit 3a9e6e5 into master Apr 22, 2020
@3h4x 3h4x deleted the kiam-supporting-imdsv2 branch April 22, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximmi maximmi maximmi approved these changes

@goruha goruha Awaiting requested review from goruha

@osterman osterman Awaiting requested review from osterman

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3h4x @maximmi