Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket settings #130

Merged
merged 30 commits into from
Nov 11, 2023
Merged

Fix bucket settings #130

merged 30 commits into from
Nov 11, 2023

Conversation

max-lobur
Copy link
Contributor

what

Use standalone resource for bucket ACL

why

Regression after AWS v5 upgrade

@max-lobur max-lobur requested review from a team as code owners November 10, 2023 21:05
@max-lobur max-lobur added the minor New features that do not break anything label Nov 10, 2023
main.tf Outdated Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur added patch A minor, backward compatible change and removed minor New features that do not break anything labels Nov 10, 2023
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

main.tf Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

main.tf Outdated Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

/terratest

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur changed the title Fix bucket ACL Fix bucket settings Nov 10, 2023
@max-lobur
Copy link
Contributor Author

/terratest

main.tf Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

/terratest

main.tf Outdated Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur
Copy link
Contributor Author

/terratest

main.tf Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur merged commit 41b7d76 into main Nov 11, 2023
11 of 12 checks passed
@max-lobur max-lobur deleted the fix_acl branch November 11, 2023 00:26
@cloudposse cloudposse deleted a comment from github-actions bot Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant