-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows node not joining the eks cluster #195
Labels
bug
🐛 An issue with the system
Comments
It's failing because the userscript contains the bootstrapper in the middle; but the script that is stored in the launch template contains the bootstrapper again at the end. |
ChrisMcKee
added a commit
to ChrisMcKee/terraform-aws-eks-node-group
that referenced
this issue
Sep 18, 2024
…s in unexpected behaviour Nodes that use custom `userdata` but don't use a custom-ami are creating a launch-template with the userdata in place but AWS is then injecting their bootstrapper at the end of the userscript. This means that `after_cluster_joining_userdata` will execute before cluster registration. * Split the bootstrap out of the userdata templates into separate files, add ${bootstrap_script} into files in its place * `launch_template.tf` Add precondition check; If `after_cluster_joining_userdata` is set but `ami_image_id` isn't and the OS is AL2/WINDOWS, show error * `userdata.tf` Add `bootstrap_script` to local.userdata_vars; load in the userdata_bootstrap* file for the OS if the OS is AL2/Windows, otherwise, use empty string. * `variables.tf` Add further detail to `after_cluster_joining_userdata`
ChrisMcKee
added a commit
to ChrisMcKee/terraform-aws-eks-node-group
that referenced
this issue
Sep 19, 2024
…s in unexpected behaviour Nodes that use custom `userdata` but don't use a custom-ami are creating a launch-template with the userdata in place but AWS is then injecting their bootstrapper at the end of the userscript. This means that `after_cluster_joining_userdata` will execute before cluster registration. * Split the bootstrap out of the userdata templates into separate files, add ${bootstrap_script} into files in its place * `launch_template.tf` Add precondition check; If `after_cluster_joining_userdata` is set but `ami_image_id` isn't and the OS is AL2/WINDOWS, show error * `userdata.tf` Add `bootstrap_script` to local.userdata_vars; load in the userdata_bootstrap* file for the OS if the OS is AL2/Windows, otherwise, use empty string. * `variables.tf` Add further detail to `after_cluster_joining_userdata`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
I am using below config to create a windows node group using the latest version of the module, node gets created but fails to join the cluster.
Expected Behavior
Node should join the cluster
Steps to Reproduce
If you have existing cluster just try creating the windows node group into that
Screenshots
No response
Environment
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: