fix(#195): UserData behaviour change between 2 and 3 breaks order of execution #198
+73
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 This pull request now has conflicts. Could you fix it @ChrisMcKee? 🙏 |
ChrisMcKee
force-pushed
the
fix-userdata
branch
from
7d10ade
to
0b88ed0
Compare
…s in unexpected behaviour
Nodes that use custom `userdata` but don't use a custom-ami are creating a launch-template with the userdata in place
but AWS is then injecting their bootstrapper at the end of the userscript.
This means that `after_cluster_joining_userdata` will execute before cluster registration.
* Split the bootstrap out of the userdata templates into separate files, add ${bootstrap_script} into files in its place
* `launch_template.tf` Add precondition check; If `after_cluster_joining_userdata` is set but `ami_image_id` isn't and the OS is AL2/WINDOWS, show error
* `userdata.tf` Add `bootstrap_script` to local.userdata_vars; load in the userdata_bootstrap* file for the OS if the OS is AL2/Windows, otherwise, use empty string.
* `variables.tf` Add further detail to `after_cluster_joining_userdata`
Nuru
added
do not merge
|
Hopefully this PR will be rendered unnecessary by #200 and can be closed without merging. I would prefer not to mess with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
launch_template.tfAdd precondition check; Ifafter_cluster_joining_userdatais set butami_image_idisn't and the OS is AL2/WINDOWS, show erroruserdata.tfAddbootstrap_scriptto local.userdata_vars; load in the userdata_bootstrap* file for the OS if the OS is AL2/Windows, otherwise, use empty string.variables.tfAdd further detail toafter_cluster_joining_userdatawhy
Nodes that use custom
userdatabut don't use a custom-ami are creating a launch-template with the userdata in place but AWS is then injecting their bootstrapper at the end of the userscript. This means thatafter_cluster_joining_userdatawill execute before cluster registration.references
closes #195