Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missed tags #191

Merged
merged 4 commits into from
Aug 8, 2024
Merged

feat: Add missed tags #191

merged 4 commits into from
Aug 8, 2024

Conversation

MaxymVlasov
Copy link
Contributor

what

Add tags to resources where they missed

@MaxymVlasov MaxymVlasov requested review from a team as code owners August 8, 2024 15:28
@mergify mergify bot added the triage Needs triage label Aug 8, 2024
@aknysh aknysh added minor New features that do not break anything and removed triage Needs triage labels Aug 8, 2024
@aknysh
Copy link
Member

aknysh commented Aug 8, 2024

/terratest

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MaxymVlasov

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxymVlasov

Please check

not ok 1 check if terraform outputs have descriptions

https://github.com/cloudposse/terraform-aws-eks-node-group/actions/runs/10305269133/job/28525681270?pr=191

and add missing descriptions to the main module and examples

@MaxymVlasov MaxymVlasov requested a review from aknysh August 8, 2024 15:54
@MaxymVlasov
Copy link
Contributor Author

@aknysh fixed

@aknysh
Copy link
Member

aknysh commented Aug 8, 2024

Details

@MaxymVlasov please fix the errors

https://github.com/cloudposse/terraform-aws-eks-node-group/actions/runs/10305387428/job/28526252248?pr=191

not ok 1 check if terraform outputs have descriptions
not ok 1 check if terraform code needs formatting

in the main module and all the examples

thank you

@MaxymVlasov
Copy link
Contributor Author

@aknysh try now

@aknysh
Copy link
Member

aknysh commented Aug 8, 2024

@aknysh try now

@MaxymVlasov

the code is formatted, thanks.

but still this error

not ok 1 check if terraform outputs have descriptions

please check the outputs in the module AND in the examples.

thank you

@MaxymVlasov
Copy link
Contributor Author

@aknysh it will be much more helpful if you use tflint checks, which point where issues are.
Idk why Nuru did it in this way, but I added a description to it too

image

@aknysh
Copy link
Member

aknysh commented Aug 8, 2024

/terratest

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MaxymVlasov

@aknysh aknysh merged commit e259e2d into cloudposse:main Aug 8, 2024
15 checks passed
Copy link

github-actions bot commented Aug 8, 2024

These changes were released in v3.1.0.

@MaxymVlasov MaxymVlasov deleted the patch-1 branch August 9, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants