Module modernisation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add context - upgrade for TF 0.14 - add tests - add most recent github workflows
aknysh
reviewed
Jun 16, 2021
examples/complete/provider.tf
Outdated
| provider "aws" { | ||
| region = var.region | ||
|
|
||
| # Make it faster by skipping something |
There was a problem hiding this comment.
I'd delete these, we don't use these anymore, it's fast w/o them :)
aknysh
reviewed
Jun 16, 2021
examples/complete/main.tf
Outdated
| context = module.this.context | ||
| } | ||
|
|
||
|
|
aknysh
reviewed
Jun 16, 2021
aknysh
reviewed
Jun 16, 2021
* remove marbot example * formatting * remove provider block also: * add versions.tf to examples/complete/
|
@aknysh hopefully all addressed |
aknysh
approved these changes
Jun 17, 2021
|
@joe-niland approved, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references