Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable AWS route creation and deletion timeouts #57

Merged
merged 7 commits into from
Jun 18, 2022

Conversation

morremeyer
Copy link
Contributor

what

  • Adds configurable timeouts for AWS route creation and deletion

why

  • Route creation and deletion can take longer than the provider defaults of 2m (creation) and 5m (deletion)

references

@morremeyer morremeyer marked this pull request as ready for review February 18, 2022 18:23
@morremeyer morremeyer requested review from a team as code owners February 18, 2022 18:23
@morremeyer morremeyer requested review from Makeshift and joe-niland and removed request for a team February 18, 2022 18:23
variables.tf Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

I used the default 5m timeout for create, removed the null provider, and hopefully copying versions.tf into examples/complete will fix the tests.

@nitrocode nitrocode merged commit 67f1be2 into cloudposse:master Jun 18, 2022
@nitrocode
Copy link
Member

Thanks @morremeyer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants