Fix Default Route Table

[Benbentwo]

what

• Reverts PR Update accepter, GitHub actions, LICENSE, README #44 which introduced a bug when using default routing table

references

• Fixes Module fails if subnet uses default "main" routing table #45
• Reopens accepter_subnet_tags doesn't have any effect #30

[Benbentwo]

/test all

[aknysh]

please see comments

[Nuru]

The aws_subnet_ids resource has been deprecated, and we should use aws_subnets instead.

Although aws_route_table has not been deprecated, we should probably use aws_route_tables instead, as it has the cleaner, more modern interface.

We can fix the original bug by looking up the default route table and using it if no route table is found to be associated with the subnet.

This Pull Request has been updated, so we're dismissing all reviews.

[Benbentwo]

I believe I addressed your comments. using aws_subnet_ids now.

We we're already using aws_route_tables in the PR so nothing changed there. Tested with one using default route table, and one without.

[Benbentwo]

/test all

[Nuru]

Backtracking on removing sort for data from data sources, since it seems to work. See other comments.

This Pull Request has been updated, so we're dismissing all reviews.

[Benbentwo]

/test all

[Benbentwo]

/test all

[Benbentwo]

/test all

[aknysh]

@Benbentwo a few nitpicks

[Nuru]

/test all

This Pull Request has been updated, so we're dismissing all reviews.

[Nuru]

/test all