Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove provider migrations #731

Merged
merged 25 commits into from
May 24, 2022

Conversation

disq
Copy link
Member

@disq disq commented May 17, 2022

No description provided.

@disq disq force-pushed the feat/remove-provider-migrations branch from 99eb888 to ad44899 Compare May 17, 2022 15:03
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, gave initial batch of comments, waiting for SDK PR so I can see the bigger picture and maybe have more comments. The only main one to be aware as we drop data, any sync with "newer" version will drop all data, which can cause issues for any command that isn't fetch basically.

pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/state/client.go Outdated Show resolved Hide resolved
@disq disq marked this pull request as ready for review May 18, 2022 16:09
@disq disq requested a review from a team as a code owner May 18, 2022 16:09
@disq disq requested review from yevgenypats and removed request for a team May 18, 2022 16:09
@disq disq requested a review from bbernays May 18, 2022 19:18
@disq disq requested a review from roneli May 19, 2022 10:46
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, didn't approve as day off today and didn't run it / check it out locally. But overall mostly minor comments.

pkg/core/fetch.go Outdated Show resolved Hide resolved
pkg/core/state/provider.go Outdated Show resolved Hide resolved
pkg/core/sync.go Show resolved Hide resolved
pkg/core/sync.go Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
pkg/core/sync.go Outdated Show resolved Hide resolved
@disq disq mentioned this pull request May 19, 2022
5 tasks
@disq disq requested a review from roneli May 19, 2022 12:33
pkg/core/sync.go Outdated Show resolved Hide resolved
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disq disq changed the title feat: Remove provider migrations feat!: Remove provider migrations May 23, 2022
@yevgenypats yevgenypats merged commit bb93967 into cloudquery:main May 24, 2022
kodiakhq bot pushed a commit that referenced this pull request May 24, 2022
🤖 I have created a release *beep* *boop*
---


## [0.24.0](v0.23.4...v0.24.0) (2022-05-24)


### ⚠ BREAKING CHANGES

* Remove provider migrations (#731)

### Features

* Classify some policy download errors as USER ([#742](#742)) ([8224e60](8224e60))
* Remove provider migrations ([#731](#731)) ([bb93967](bb93967))


### Bug Fixes

* Added root policy config inheritance to selected subpolicy ([#702](#702)) ([0d8b3c7](0d8b3c7))
* Check policy version on it's core version ([#773](#773)) ([c7c9ad0](c7c9ad0))
* Classify "no policies in config" as USER error ([#743](#743)) ([4cbc03e](4cbc03e))
* **deps:** Update SDK ([#758](#758)) ([c9b4094](c9b4094))
* Diag import clean up ([#744](#744)) ([437c956](437c956))
* Don't attempt to download provider in re-attach mode ([#748](#748)) ([59973b8](59973b8))
* FetchId column regression ([#745](#745)) ([585d395](585d395))
* Handle DeadlineExceeded errors ([#741](#741)) ([0167ce4](0167ce4))
* Handle Outputting Policies With Selectors ([a3ecfc9](a3ecfc9))
* Policy executor ([#769](#769)) ([d5b6aef](d5b6aef))
* Policy output file name ([#770](#770)) ([1a87c25](1a87c25))
* Space trimming in telemetry file ([#734](#734)) ([16c4cfc](16c4cfc))
* Upgrade protocol version to V5 ([#774](#774)) ([69b405d](69b405d))
* Use consistent descriptions for flags ([#753](#753)) ([cedeb3d](cedeb3d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants