-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove provider migrations #731
feat!: Remove provider migrations #731
Conversation
99eb888
to
ad44899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, gave initial batch of comments, waiting for SDK PR so I can see the bigger picture and maybe have more comments. The only main one to be aware as we drop data, any sync with "newer" version will drop all data, which can cause issues for any command that isn't fetch basically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, didn't approve as day off today and didn't run it / check it out locally. But overall mostly minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 I have created a release *beep* *boop* --- ## [0.24.0](v0.23.4...v0.24.0) (2022-05-24) ### ⚠ BREAKING CHANGES * Remove provider migrations (#731) ### Features * Classify some policy download errors as USER ([#742](#742)) ([8224e60](8224e60)) * Remove provider migrations ([#731](#731)) ([bb93967](bb93967)) ### Bug Fixes * Added root policy config inheritance to selected subpolicy ([#702](#702)) ([0d8b3c7](0d8b3c7)) * Check policy version on it's core version ([#773](#773)) ([c7c9ad0](c7c9ad0)) * Classify "no policies in config" as USER error ([#743](#743)) ([4cbc03e](4cbc03e)) * **deps:** Update SDK ([#758](#758)) ([c9b4094](c9b4094)) * Diag import clean up ([#744](#744)) ([437c956](437c956)) * Don't attempt to download provider in re-attach mode ([#748](#748)) ([59973b8](59973b8)) * FetchId column regression ([#745](#745)) ([585d395](585d395)) * Handle DeadlineExceeded errors ([#741](#741)) ([0167ce4](0167ce4)) * Handle Outputting Policies With Selectors ([a3ecfc9](a3ecfc9)) * Policy executor ([#769](#769)) ([d5b6aef](d5b6aef)) * Policy output file name ([#770](#770)) ([1a87c25](1a87c25)) * Space trimming in telemetry file ([#734](#734)) ([16c4cfc](16c4cfc)) * Upgrade protocol version to V5 ([#774](#774)) ([69b405d](69b405d)) * Use consistent descriptions for flags ([#753](#753)) ([cedeb3d](cedeb3d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.