fix: Remove always nil return value #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
May 24, 2022
| @@ -175,7 +175,6 @@ func (p *Parser) interpret(cfg *BaseConfig) hcl.Diagnostics { | |||
| } | |||
| } | |||
| } | |||
| return nil | |||
There was a problem hiding this comment.
Return value is always nil and will actually cause a panic in callers I believe
There was a problem hiding this comment.
hcl.Diagnostics is a slice:
type Diagnostics []*Diagnosticnil slice is valid and diags.HasErrors won't cause panic.
There was a problem hiding this comment.
There was a problem hiding this comment.
Cool, thanks for the context. Should we still remove the return value? It's not used
disq
approved these changes
May 24, 2022
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
May 27, 2022
* upstream/main: (22 commits) fix: Skip reattached provider update checks (cloudquery#801) fix: Add Git Binary To Docker chore(main): Release v0.24.1 (cloudquery#780) fix: Test flakiness (cloudquery#790) feat: Store Policy Output (cloudquery#709) fix: Panic in loadPolicyFromSource (cloudquery#787) fix: Panic in OsFs.downloadFile (cloudquery#789) fix: Error classifier improvements (cloudquery#788) fix: Console log log level (cloudquery#786) refactor: Use pointer for connection receiver (cloudquery#782) fix(deps): Update module github.com/cloudquery/cq-provider-sdk to v0.10.2 (cloudquery#784) refactor: Use copy instead of loop (cloudquery#781) fix: Remove always nil return value (cloudquery#778) test(fetch): Fix assertions to match new test provider (cloudquery#777) test(fetch): Pin test provider version (cloudquery#776) chore(main): Release v0.24.0 (cloudquery#749) fix: Upgrade protocol version to V5 (cloudquery#774) fix: Check policy version on it's core version (cloudquery#773) fix: Policy output file name (cloudquery#770) fix: Policy executor (cloudquery#769) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
New linter caught this. I'm doing this in a separate PR to make verifying the change easier
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run --new-from-rev main🚨 (install golangci-lint here)