Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Added not found errors handlers in athena resources #1021

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Jun 8, 2022

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

  • fixes some not handled not found errors after list
  • added handler when QueryExecution is not found (api returns InvalidRequestException )

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@amanenk amanenk marked this pull request as ready for review June 8, 2022 14:04
@amanenk amanenk requested a review from a team as a code owner June 8, 2022 14:04
@amanenk amanenk requested review from yevgenypats and removed request for a team June 8, 2022 14:04
resources/services/athena/work_groups.go Outdated Show resolved Hide resolved
@amanenk amanenk marked this pull request as draft June 8, 2022 14:08
@amanenk amanenk marked this pull request as ready for review June 9, 2022 11:14
@amanenk amanenk requested a review from bbernays June 9, 2022 11:14
@amanenk amanenk merged commit f18abef into cloudquery:main Jun 13, 2022
bbernays pushed a commit to bbernays/cq-provider-aws that referenced this pull request Jun 13, 2022
…y#1021)

* fix: Added not found checks in athena workgroups

* added data catalogs

* removed region argument, added error handler
kodiakhq bot pushed a commit that referenced this pull request Jun 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.12.10](v0.12.9...v0.12.10) (2022-06-13)


### Bug Fixes

* Added `not found` errors handlers in athena resources ([#1021](#1021)) ([f18abef](f18abef))
* Added `not found` errors handlers in athena resources ([#1021](#1021)) ([297fa6c](297fa6c))
* change from IgnoreAccessDeniedServiceDisabled to IgnoreCommonErrors ([#1033](#1033)) ([1b98229](1b98229))
* Redshift Panic when accessing nested attributes ([8bae50b](8bae50b))
* Update endpoints ([#1032](#1032)) ([bd6159a](bd6159a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit to cloudquery/cloudquery that referenced this pull request Aug 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.12.10](cloudquery/cq-provider-aws@v0.12.9...v0.12.10) (2022-06-13)


### Bug Fixes

* Added `not found` errors handlers in athena resources ([#1021](cloudquery/cq-provider-aws#1021)) ([f18abef](cloudquery/cq-provider-aws@f18abef))
* Added `not found` errors handlers in athena resources ([#1021](cloudquery/cq-provider-aws#1021)) ([297fa6c](cloudquery/cq-provider-aws@297fa6c))
* change from IgnoreAccessDeniedServiceDisabled to IgnoreCommonErrors ([#1033](cloudquery/cq-provider-aws#1033)) ([1b98229](cloudquery/cq-provider-aws@1b98229))
* Redshift Panic when accessing nested attributes ([8bae50b](cloudquery/cq-provider-aws@8bae50b))
* Update endpoints ([#1032](cloudquery/cq-provider-aws#1032)) ([bd6159a](cloudquery/cq-provider-aws@bd6159a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants