Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

chore: Update SDK to v0.11.0 #1022

Closed
wants to merge 1 commit into from
Closed

chore: Update SDK to v0.11.0 #1022

wants to merge 1 commit into from

Conversation

yevgenypats
Copy link
Member

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Updated to SDK v0.11.0 https://github.com/cloudquery/cq-provider-sdk/releases/tag/v0.11.0


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@yevgenypats yevgenypats requested a review from a team as a code owner June 8, 2022 14:22
@yevgenypats yevgenypats requested review from disq and erezrokah and removed request for a team June 8, 2022 14:22
@erezrokah
Copy link
Member

erezrokah commented Jun 8, 2022

@yevgenypats FYI you can generate the update PRs for all repos by running the renovate workflow manually (it runs every 15 minutes regardless). See https://github.com/cloudquery/.github/actions/workflows/renovate.yml.

Usually those will get auto merged, but since this is a breaking change our bots will not merge it:
https://github.com/cloudquery/.github/blob/21d36504ad0ebe7c9accb0db8ae3d0a71850c1f3/.github/.kodiak.toml#L12

@yevgenypats
Copy link
Member Author

@erezrokah I assumed so but I also had to remove some columns that we ignored so I though it would fail but cool, will wait for that :)

@erezrokah
Copy link
Member

erezrokah commented Jun 8, 2022

Ah, cool - it's there #1023 so if you'd like you can commit the changes to that PR. Doesn't really matter (the bot PRs include the SDK changelog in the description so it's nice to have for reference)

@yevgenypats
Copy link
Member Author

Sounds good will commit there.

@yevgenypats yevgenypats closed this Jun 8, 2022
@erezrokah erezrokah deleted the feat/update_sdk branch June 8, 2022 15:12
@erezrokah erezrokah restored the feat/update_sdk branch June 8, 2022 15:12
@erezrokah erezrokah deleted the feat/update_sdk branch June 12, 2022 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants