Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added glue data catalog encryption settings #1356

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Aug 1, 2022

Summary

closes #1329

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

@amanenk amanenk marked this pull request as ready for review August 1, 2022 12:47
@amanenk amanenk requested a review from a team as a code owner August 1, 2022 12:47
@amanenk amanenk requested review from roneli and removed request for a team August 1, 2022 12:47
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…settings

# Conflicts:
#	client/mocks/glue.go
#	client/services.go
#	resources/provider/provider.go
@amanenk amanenk merged commit a6c6246 into cloudquery:main Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::Glue::DataCatalogEncryptionSettings
2 participants