Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Add ELBv2 attributes #177

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Add ELBv2 attributes #177

merged 2 commits into from
Sep 8, 2021

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Sep 7, 2021

No description provided.

@irmatov
Copy link
Contributor Author

irmatov commented Sep 7, 2021

Closes cloudquery/cloudquery#187

roneli
roneli suggested changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick look I think attributes that we know exist should be transformed into columns rather than a json.

see:
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html#load-balancer-attributes

https://docs.aws.amazon.com/elasticloadbalancing/latest/network/network-load-balancers.html#load-balancer-attributes

https://docs.aws.amazon.com/elasticloadbalancing/latest/gateway/gateway-load-balancers.html#load-balancer-attributes

roneli
roneli suggested changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a few comments.

resources/mq_brokers.go Show resolved Hide resolved
resources/elbv2_load_balancers.go Show resolved Hide resolved
@roneli roneli merged commit d22d976 into cloudquery:main Sep 8, 2021
@irmatov irmatov deleted the elbv2_attrs branch September 8, 2021 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irmatov @roneli