Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat/ignore unsupported regions errors #214

Merged
merged 6 commits into from
Oct 21, 2021

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Oct 19, 2021

fixes #210

@amanenk amanenk requested a review from roneli October 19, 2021 06:43
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some comments regarding parsing and matching

client/helpers.go Outdated Show resolved Hide resolved
client/helpers.go Outdated Show resolved Hide resolved
client/helpers.go Outdated Show resolved Hide resolved
@amanenk amanenk requested a review from roneli October 19, 2021 12:00
@roneli roneli changed the title poc of non supported regions errors ignoring feat/ignore unsupported regions errors Oct 19, 2021
client/helpers.go Outdated Show resolved Hide resolved
@amanenk amanenk requested a review from roneli October 19, 2021 18:04
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 2 nit picks

client/helpers.go Show resolved Hide resolved
client/helpers.go Show resolved Hide resolved
@amanenk amanenk requested a review from roneli October 21, 2021 14:37
@roneli roneli merged commit 4ab7f66 into cloudquery:main Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check supported regions when all regions available
2 participants