Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Implement EMR Block Public Access resource #269

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Implement EMR Block Public Access resource #269

merged 1 commit into from
Nov 22, 2021

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Nov 19, 2021 •
edited
Loading

Closes #249

roneli
roneli approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amanenk
amanenk approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 for not forgetting to add e2e tests

@roneli roneli merged commit d1f3472 into cloudquery:main Nov 22, 2021
@irmatov irmatov deleted the emr_block_public_access branch November 30, 2021 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amanenk amanenk amanenk approved these changes

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EMR Block Public Access
3 participants
@irmatov @amanenk @roneli