This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
Support S3 Account Settings #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
previously requested changes
Nov 23, 2021
roneli
suggested changes
Nov 23, 2021
There was a problem hiding this comment.
LGTM, had one suggestion + as @yevgenypats we should add e2e + mock tests
roneli
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
LGTM, added one suggestion to make the flow cleaner, I think you can also add account id to the initialization and remove initialization in lines 69-71.
Still missing mock tests for sanity + e2e tests I think no terraform is required, just a fetching the data and verifying values worked.
bbernays
changed the title
disq
approved these changes
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #282