Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

support regions table #293

Merged
merged 8 commits into from
Nov 24, 2021
Merged

support regions table #293

merged 8 commits into from
Nov 24, 2021

Conversation

roneli
Copy link
Contributor

@roneli roneli commented Nov 23, 2021

No description provided.

@roneli roneli requested a review from bbernays November 23, 2021 17:16
bbernays
bbernays reviewed Nov 23, 2021
View reviewed changes
Copy link
Contributor

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What about e2e tests?

resources/provider.go Outdated Show resolved Hide resolved
bbernays
bbernays approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... Did you decide not to change the name of the resource from regions to aws.regions?

@roneli roneli merged commit e493e60 into cloudquery:main Nov 24, 2021
@roneli roneli deleted the feat/support_enabled_regions_table branch November 24, 2021 12:56
@roneli
Copy link
Contributor Author

roneli commented Nov 26, 2021

Closed #263

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbernays bbernays bbernays approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roneli @bbernays