-
Notifications
You must be signed in to change notification settings - Fork 40
Add support for Elasticbeanstalk Applications #316
Add support for Elasticbeanstalk Applications #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. I have left a few minor comments/ suggestions.
Also it seems like we can make config_options
and config_settings
a relation of existing environments resource. That way we will not fetch environments three times.
resources/integration_tests/aws_elasticbeanstalk_environments_test.go
Outdated
Show resolved
Hide resolved
…/bbernays/cq-provider-aws into Add-Support-for-Elasticbeanstalk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes requested, two tables can be folded as relations instead of being their own resource, it also reduces the load of calling describe environment so many times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.