Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Add support for Elasticbeanstalk Applications #316

Merged
merged 46 commits into from
Dec 2, 2021
Merged

Add support for Elasticbeanstalk Applications #316

merged 46 commits into from
Dec 2, 2021

Conversation

bbernays
Copy link
Contributor

No description provided.

@bbernays bbernays marked this pull request as draft November 30, 2021 12:22
@roneli roneli requested a review from irmatov December 1, 2021 12:52
irmatov
irmatov reviewed Dec 1, 2021
View reviewed changes
Copy link
Contributor

@irmatov irmatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. I have left a few minor comments/ suggestions.

Also it seems like we can make config_options and config_settings a relation of existing environments resource. That way we will not fetch environments three times.

resources/elasticbeanstalk_configuration_options.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_applications_test.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_configuration_options.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_configuration_options_test.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_configuration_settings.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_configuration_settings.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_configuration_settings.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_configuration_settings.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_envrionments_test.go Outdated Show resolved Hide resolved
resources/integration_tests/aws_elasticbeanstalk_environments_test.go Outdated Show resolved Hide resolved
@bbernays bbernays marked this pull request as ready for review December 1, 2021 15:44
@roneli roneli changed the title [WIP] Add support for Elasticbeanstalk Applications Add support for Elasticbeanstalk Applications Dec 1, 2021
@bbernays bbernays requested a review from irmatov December 1, 2021 20:49
roneli
roneli suggested changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested, two tables can be folded as relations instead of being their own resource, it also reduces the load of calling describe environment so many times.

.gitignore Outdated Show resolved Hide resolved
resources/elasticbeanstalk_applications.go Show resolved Hide resolved
resources/elasticbeanstalk_configuration_options.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_configuration_settings.go Outdated Show resolved Hide resolved
resources/elasticbeanstalk_configuration_settings.go Outdated Show resolved Hide resolved
roneli
roneli approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

roneli
roneli approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit cfef94c into cloudquery:main Dec 2, 2021
@bbernays bbernays deleted the Add-Support-for-Elasticbeanstalk branch December 2, 2021 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

@irmatov irmatov Awaiting requested review from irmatov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbernays @irmatov @roneli