Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Add RDS event subscriptions #322

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Add RDS event subscriptions #322

merged 5 commits into from
Dec 3, 2021

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Dec 2, 2021

No description provided.

roneli
roneli suggested changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PK, we should also want to add some e2e testing for this resource

resources/rds_event_subscriptions.go Show resolved Hide resolved
amanenk
amanenk approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@irmatov
Copy link
Contributor Author

irmatov commented Dec 3, 2021

e2e test added

@irmatov irmatov requested a review from roneli December 3, 2021 08:09
roneli
roneli approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit 415d59d into cloudquery:main Dec 3, 2021
@irmatov irmatov deleted the rds_event_subscriptions branch December 3, 2021 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amanenk amanenk amanenk approved these changes

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irmatov @amanenk @roneli