This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
Create Makefile #330
Merged
Create Makefile #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
suggested changes
Dec 3, 2021
Makefile
Outdated
| curl -L https://github.com/cloudquery/cloudquery/releases/latest/download/cloudquery_Darwin_x86_64 -o cloudquery | ||
| chmod +x ./cloudquery | ||
|
|
||
| install-cq-mac: |
There was a problem hiding this comment.
what's the difference between install-cq, install-cq-mac (twice). I think we can get the OS and the arch automatically and put it in an env?
There was a problem hiding this comment.
If we can't, how about mac-m1? Or how about this:
install-cq:
@echo Go to https://docs.cloudquery.io/install-instructions and do the thing there please
(ie. I'm questioning whether it's needed to have it here)
There was a problem hiding this comment.
I left install-cq target in there because that is what I use. I would love to support automatically detecting arch and os.
There was a problem hiding this comment.
I added the instructions under this target. When we can support dynamic detection we can replace it with the automated install
disq
approved these changes
Dec 3, 2021
disq
approved these changes
Dec 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to develop the
cq-provider-awsyou can run a specific e2e test like this: