Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Add more RDS resources #333

Merged
merged 6 commits into from
Dec 9, 2021
Merged

Add more RDS resources #333

merged 6 commits into from
Dec 9, 2021

Conversation

irmatov
Copy link
Contributor

@irmatov irmatov commented Dec 6, 2021 •
edited
Loading

  • RDS Cluster parameter groups
  • RDS DB parameter groups
  • RDS DB security groups

@irmatov irmatov changed the title Add RDS DB and cluster parameter groups resource Add more RDS resources Dec 7, 2021
roneli
roneli approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had minor taste of choice change requests but looks good.

resources/rds_cluster_parameter_groups.go Outdated Show resolved Hide resolved
resources/rds_db_parameter_groups.go Outdated Show resolved Hide resolved
amanenk
amanenk reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. only one minor suggestion

resources/rds_cluster_parameter_groups.go Outdated Show resolved Hide resolved
@irmatov irmatov requested a review from amanenk December 9, 2021 07:56
@roneli roneli merged commit e089891 into cloudquery:main Dec 9, 2021
@irmatov irmatov deleted the rds_parameters_groups branch December 9, 2021 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

@amanenk amanenk Awaiting requested review from amanenk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irmatov @amanenk @roneli