Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Fix elasticsearch domains PK #384

Merged
merged 3 commits into from
Dec 31, 2021
Merged

Fix elasticsearch domains PK #384

merged 3 commits into from
Dec 31, 2021

Conversation

disq
Copy link
Member

@disq disq commented Dec 30, 2021

ElasticSearch domains are unique per region but the PK was defined as account_id, id.

Manually tested in a "throwaway" AWS account.

@disq disq requested a review from roneli December 30, 2021 12:17
roneli
roneli suggested changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had minor nitpick on pk order

resources/services/elasticsearch/elasticsearch_domains.go Outdated Show resolved Hide resolved
@disq disq requested a review from roneli December 30, 2021 17:39
@yevgenypats yevgenypats merged commit ec99df4 into main Dec 31, 2021
@yevgenypats yevgenypats deleted the fix/elasticsearch-multi-region branch December 31, 2021 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disq @roneli @yevgenypats