This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
WIP: Fix regions filtering overriding for each account #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #391.
As uncovered in #391 this line of detecting which regions are enabled in a specific account is overriding all the accounts. Moreover we don't need the
regions
field on the client level as this is incorrect and it should be only specified on the account level (even though we can have in the config).Also, as noted in this comment by @bbernays we don't need the list of regions at all, this also remove the burden of maintaining it.
I'll test it manually but also I think we might need some additional testing here as it's a bit hard to verify manually all the edge-cases.