Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

WIP: Fix regions filtering overriding for each account #395

Closed
wants to merge 1 commit into from

Conversation

yevgenypats
Copy link
Member

@yevgenypats yevgenypats commented Jan 8, 2022

This is a continuation of #391.

As uncovered in #391 this line of detecting which regions are enabled in a specific account is overriding all the accounts. Moreover we don't need the regions field on the client level as this is incorrect and it should be only specified on the account level (even though we can have in the config).

Also, as noted in this comment by @bbernays we don't need the list of regions at all, this also remove the burden of maintaining it.

I'll test it manually but also I think we might need some additional testing here as it's a bit hard to verify manually all the edge-cases.

@yevgenypats
Copy link
Member Author

Closing - Fixed in #391

@yevgenypats yevgenypats closed this Jan 8, 2022
@yevgenypats yevgenypats deleted the fix/incorrect_filter_multiplex branch January 8, 2022 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant