This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
test: Refactor integration tests #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All integration tests now run from TestIntegration. This makes the tests faster and remove huge amount of connection to the database. Also remove bash magic to test for warnings using grep and do all the checks on the SDK level.
yevgenypats
force-pushed
the
test/improve_integration_tests
branch
from
a60315a
to
0f1a03a
Compare
yevgenypats
added a commit
to cloudquery/cq-provider-sdk
that referenced
this pull request
Jan 28, 2022
fix: Child tables weren't deleted test: split to subtest with t.Run for each table Related PR: cloudquery/cq-provider-aws#450
Use only golang_lint.yml and doc_validation.yml that are managed centerally under cloudquery/.github repo
yevgenypats
added a commit
to cloudquery/cq-provider-sdk
that referenced
this pull request
Jan 30, 2022
fix: Child tables weren't deleted test: split to subtest with t.Run for each table Related PR: cloudquery/cq-provider-aws#450
yevgenypats
added a commit
to cloudquery/cq-provider-sdk
that referenced
this pull request
Jan 30, 2022
fix: Child tables weren't deleted test: split to subtest with t.Run for each table Related PR: cloudquery/cq-provider-aws#450
yevgenypats
force-pushed
the
test/improve_integration_tests
branch
from
5b9ef05
to
4805501
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All integration tests now run from TestIntegration.
This makes the tests faster and remove huge amount of connection
to the database.
Also remove bash magic to test for warnings using grep and do
all the checks on the SDK level.