Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added Athena resources: data_catalogs, work_groups, named_queries, prepared_statements #804

Merged
merged 33 commits into from
May 12, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Apr 27, 2022

closes #788
and its sub-tasks:
closes #789
closes #790
closes #791
closes #792
fixed migration

@github-actions github-actions bot added the feat label Apr 27, 2022
@amanenk amanenk marked this pull request as ready for review April 29, 2022 12:22
@amanenk amanenk requested a review from a team as a code owner April 29, 2022 12:22
@amanenk amanenk requested review from bbernays and removed request for a team April 29, 2022 12:22
@amanenk amanenk requested a review from roneli May 2, 2022 15:15
@github-actions
Copy link

github-actions bot commented May 2, 2022

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output

Success! The configuration is valid.


Terraform Plan success

Show Plan

module.demo.aws_kms_key.example: Refreshing state... [id=c79f8a99-3731-4123-a36c-ca7a512c1e27]
module.demo.aws_xray_encryption_config.xray-enc-conf: Refreshing state... [id=us-east-1]

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

  # module.demo.aws_kms_key.example has changed
  ~ resource "aws_kms_key" "example" {
        id                                 = "c79f8a99-3731-4123-a36c-ca7a512c1e27"
      + tags                               = {}
        # (12 unchanged attributes hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

No changes. Your infrastructure matches the configuration.

Your configuration already matches the changes detected above. If you'd like
to update the Terraform state to match, create and apply a refresh-only plan:
  terraform apply -refresh-only

Pusher: @amanenk, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

@github-actions
Copy link

github-actions bot commented May 2, 2022

💰 Infracost estimate: monthly cost will decrease by $1.00 (0%) 📉

Project Previous New Diff
cloudquery/cq-provider-aws/terraform/wafv2/prod/plan.json $6.00 $5.00 -$1.00 (-17%)
All projects $421 $420 -$1.00 (0%)

24 projects have no cost estimate changes.

Infracost output
──────────────────────────────────
Project: cloudquery/cq-provider-aws/terraform/wafv2/prod/plan.json

~ module.demo.aws_wafv2_web_acl.wafv2_web_acl
  -$1.00 ($6.00 → $5.00)

    - Rules
      -$1.00

Monthly cost change for cloudquery/cq-provider-aws/terraform/wafv2/prod/plan.json
Amount:  -$1.00 ($6.00 → $5.00)
Percent: -17%

──────────────────────────────────

The following projects have no cost estimate changes: cloudquery/cq-provider-aws/terraform/accessanalyzer/prod/plan.json, cloudquery/cq-provider-aws/terraform/apigateway2/prod/plan.json, cloudquery/cq-provider-aws/terraform/autoscaling/prod/plan.json, cloudquery/cq-provider-aws/terraform/backup/prod/plan.json, cloudquery/cq-provider-aws/terraform/cloudformation/prod/plan.json, cloudquery/cq-provider-aws/terraform/codepipeline/prod/plan.json, cloudquery/cq-provider-aws/terraform/ec2/prod/plan.json, cloudquery/cq-provider-aws/terraform/ecs/prod/plan.json, cloudquery/cq-provider-aws/terraform/elasticbeanstalk/prod/plan.json, cloudquery/cq-provider-aws/terraform/iot/prod/plan.json, cloudquery/cq-provider-aws/terraform/lambda/prod/plan.json, cloudquery/cq-provider-aws/terraform/mq/prod/plan.json, cloudquery/cq-provider-aws/terraform/qldb/prod/plan.json, cloudquery/cq-provider-aws/terraform/rds/prod/plan.json, cloudquery/cq-provider-aws/terraform/redshift/prod/plan.json, cloudquery/cq-provider-aws/terraform/s3/prod/plan.json, cloudquery/cq-provider-aws/terraform/sagemaker/prod/plan.json, cloudquery/cq-provider-aws/terraform/sns/prod/plan.json, cloudquery/cq-provider-aws/terraform/sqs/prod/plan.json, cloudquery/cq-provider-aws/terraform/ssm/prod/plan.json, cloudquery/cq-provider-aws/terraform/waf/prod/plan.json, cloudquery/cq-provider-aws/terraform/wafregional/prod/plan.json, cloudquery/cq-provider-aws/terraform/workspaces/prod/plan.json, cloudquery/cq-provider-aws/terraform/xray/prod/plan.json
Run infracost breakdown to see their breakdown.

──────────────────────────────────
Key: ~ changed, + added, - removed

254 cloud resources were detected:
∙ 37 were estimated, 32 of which include usage-based costs, see https://infracost.io/usage-file
∙ 187 were free:
  ∙ 24 x aws_route_table_association
  ∙ 24 x aws_subnet
  ∙ 19 x aws_route_table
  ∙ 11 x aws_ecs_task_definition
  ∙ 11 x aws_iam_role
  ∙ 9 x aws_iam_role_policy_attachment
  ∙ 8 x aws_security_group
  ∙ 6 x aws_route
  ∙ 6 x aws_security_group_rule
  ∙ 6 x aws_vpc
  ∙ 4 x aws_iam_policy
  ∙ 4 x aws_s3_bucket_public_access_block
  ∙ 4 x aws_ssm_parameter
  ∙ 3 x aws_apigatewayv2_integration
  ∙ 3 x aws_apigatewayv2_route
  ∙ 3 x aws_s3_bucket_acl
  ∙ 2 x aws_db_subnet_group
  ∙ 2 x aws_iam_role_policy
  ∙ 2 x aws_internet_gateway
  ∙ 2 x aws_lambda_permission
  ∙ 2 x aws_waf_rule
  ∙ 2 x aws_wafv2_ip_set
  ∙ 2 x aws_wafv2_regex_pattern_set
  ∙ 1 x aws_apigatewayv2_stage
  ∙ 1 x aws_apigatewayv2_vpc_link
  ∙ 1 x aws_backup_plan
  ∙ 1 x aws_backup_region_settings
  ∙ 1 x aws_backup_selection
  ∙ 1 x aws_backup_vault_notifications
  ∙ 1 x aws_cloudformation_stack
  ∙ 1 x aws_ecs_cluster
  ∙ 1 x aws_ecs_cluster_capacity_providers
  ∙ 1 x aws_egress_only_internet_gateway
  ∙ 1 x aws_eip
  ∙ 1 x aws_elastic_beanstalk_application
  ∙ 1 x aws_iam_instance_profile
  ∙ 1 x aws_iot_policy
  ∙ 1 x aws_lambda_layer_version
  ∙ 1 x aws_launch_configuration
  ∙ 1 x aws_lb_listener
  ∙ 1 x aws_lb_target_group
  ∙ 1 x aws_network_interface
  ∙ 1 x aws_s3_bucket_object
  ∙ 1 x aws_sns_topic_policy
  ∙ 1 x aws_ssm_association
  ∙ 1 x aws_vpc_dhcp_options
  ∙ 1 x aws_vpc_dhcp_options_association
  ∙ 1 x aws_waf_ipset
  ∙ 1 x aws_waf_rule_group
  ∙ 1 x aws_wafv2_rule_group
  ∙ 1 x aws_wafv2_web_acl_logging_configuration
∙ 30 are not supported yet, see https://infracost.io/requested-resources:
  ∙ 2 x aws_iot_thing_group
  ∙ 1 x aws_accessanalyzer_analyzer
  ∙ 1 x aws_autoscaling_schedule
  ∙ 1 x aws_codepipeline
  ∙ 1 x aws_codepipeline_webhook
  ∙ 1 x aws_codestarconnections_connection
  ∙ 1 x aws_elastic_beanstalk_application_version
  ∙ 1 x aws_iot_certificate
  ∙ 1 x aws_iot_policy_attachment
  ∙ 1 x aws_iot_thing
  ∙ 1 x aws_iot_thing_group_membership
  ∙ 1 x aws_iot_thing_type
  ∙ 1 x aws_iot_topic_rule
  ∙ 1 x aws_qldb_ledger
  ∙ 1 x aws_redshift_event_subscription
  ∙ 1 x aws_redshift_parameter_group
  ∙ 1 x aws_redshift_subnet_group
  ∙ 1 x aws_s3_object
  ∙ 1 x aws_sagemaker_code_repository
  ∙ 1 x aws_sagemaker_notebook_instance
  ∙ 1 x aws_ssm_document
  ∙ 1 x aws_wafregional_ipset
  ∙ 1 x aws_wafregional_rate_based_rule
  ∙ 1 x aws_wafregional_rule
  ∙ 1 x aws_wafregional_rule_group
  ∙ 1 x aws_wafregional_web_acl
  ∙ 1 x aws_workspaces_directory
  ∙ 1 x aws_workspaces_workspace
  ∙ 1 x aws_xray_encryption_config

This comment will be updated when the cost estimate changes.

Is this comment useful? Yes, No

@amanenk amanenk changed the title feat: Added Athena Data Catalogs feat: Added Athena resources: data_catalogs, work_groups, named_queries, prepared_statements May 2, 2022
@github-actions github-actions bot added feat and removed feat labels May 2, 2022
# Conflicts:
#	resources/provider/migrations/postgres/29_v0.11.3.up.sql
#	resources/provider/migrations/timescale/29_v0.11.3.down.sql
@amanenk amanenk requested review from zagronitay and bbernays and removed request for bbernays May 10, 2022 10:32
@amanenk amanenk requested review from bbernays and disq May 11, 2022 06:58
# Conflicts:
#	resources/provider/migrations/postgres/30_v0.11.5.down.sql
#	resources/provider/migrations/postgres/30_v0.11.5.up.sql
#	resources/provider/migrations/timescale/30_v0.11.5.down.sql
#	resources/provider/migrations/timescale/30_v0.11.5.up.sql
# Conflicts:
#	resources/provider/migrations/postgres/30_v0.11.5.down.sql
#	resources/provider/migrations/postgres/30_v0.11.5.up.sql
#	resources/provider/migrations/timescale/30_v0.11.5.down.sql
#	resources/provider/migrations/timescale/30_v0.11.5.up.sql
@amanenk amanenk removed the request for review from zagronitay May 11, 2022 15:53
Copy link
Contributor

@bbernays bbernays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

client/client.go Outdated Show resolved Hide resolved
resources/provider/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanenk amanenk merged commit bf77311 into cloudquery:main May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants