This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Added Athena resources: data_catalogs, work_groups, named_queries, prepared_statements #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
reviewed
Apr 28, 2022
Terraform Format and Style
|
💰 Infracost estimate: monthly cost will decrease by $1.00 (0%) 📉
24 projects have no cost estimate changes. Infracost output
This comment will be updated when the cost estimate changes. Is this comment useful? Yes, No |
amanenk
changed the title
feat: Added Athena Data Catalogs
feat: Added Athena resources: data_catalogs, work_groups, named_queries, prepared_statements
May 2, 2022
# Conflicts: # resources/provider/migrations/postgres/29_v0.11.3.up.sql # resources/provider/migrations/timescale/29_v0.11.3.down.sql
amanenk
requested review from
zagronitay and
bbernays
and removed request for
bbernays
May 10, 2022 10:32
bbernays
reviewed
May 10, 2022
# Conflicts: # resources/provider/migrations/postgres/30_v0.11.5.down.sql # resources/provider/migrations/postgres/30_v0.11.5.up.sql # resources/provider/migrations/timescale/30_v0.11.5.down.sql # resources/provider/migrations/timescale/30_v0.11.5.up.sql
# Conflicts: # resources/provider/migrations/postgres/30_v0.11.5.down.sql # resources/provider/migrations/postgres/30_v0.11.5.up.sql # resources/provider/migrations/timescale/30_v0.11.5.down.sql # resources/provider/migrations/timescale/30_v0.11.5.up.sql
bbernays
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
disq
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
roneli
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
disq
approved these changes
May 12, 2022
This was referenced May 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #788
and its sub-tasks:
closes #789
closes #790
closes #791
closes #792
fixed migration