Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Add Partition To client #899

Merged
merged 5 commits into from
May 16, 2022
Merged

fix: Add Partition To client #899

merged 5 commits into from
May 16, 2022

Conversation

bbernays
Copy link
Contributor

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays marked this pull request as ready for review May 16, 2022 15:10
@bbernays bbernays requested a review from a team as a code owner May 16, 2022 15:10
@bbernays bbernays requested review from erezrokah, roneli, disq and irmatov and removed request for a team May 16, 2022 15:10
disq
disq approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbernays bbernays merged commit 3a77950 into cloudquery:main May 16, 2022
This was referenced May 16, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@disq disq disq approved these changes

@erezrokah erezrokah Awaiting requested review from erezrokah erezrokah is a code owner automatically assigned from cloudquery/cloudquery-opensource

@roneli roneli Awaiting requested review from roneli

@irmatov irmatov Awaiting requested review from irmatov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbernays @disq