Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Handle panic on Waf logging configuration not found #970

Merged
merged 3 commits into from
Jun 1, 2022
Merged

fix: Handle panic on Waf logging configuration not found #970

merged 3 commits into from
Jun 1, 2022

Conversation

zagronitay
Copy link
Contributor

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@zagronitay zagronitay marked this pull request as ready for review May 31, 2022 18:01
@zagronitay zagronitay requested a review from a team as a code owner May 31, 2022 18:01
@zagronitay zagronitay requested review from irmatov and removed request for a team May 31, 2022 18:01
yevgenypats
yevgenypats suggested changes May 31, 2022
View reviewed changes
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either I missed an edge or I think there is a better option to fix it with oneline instead of adding not nil everywhere

resources/services/waf/web_acls.go Outdated Show resolved Hide resolved
resources/services/waf/web_acls.go Show resolved Hide resolved
roneli
roneli approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yevgenypats yevgenypats merged commit 8ffb3e6 into cloudquery:main Jun 1, 2022
@cq-bot cq-bot mentioned this pull request Jun 1, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 1, 2022
@cq-bot
chore(main): Release v0.12.3 (#980)
49ec3fb 
🤖 I have created a release *beep* *boop*
---


### [0.12.3](v0.12.2...v0.12.3) (2022-06-01)


### Bug Fixes

* Bucket missing region ([#978](#978)) ([1467b6e](1467b6e))
* Handle panic on Waf logging configuration not found ([#970](#970)) ([8ffb3e6](8ffb3e6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yevgenypats yevgenypats yevgenypats approved these changes

@roneli roneli roneli approved these changes

@irmatov irmatov Awaiting requested review from irmatov irmatov is a code owner automatically assigned from cloudquery/cloudquery-opensource

@bbernays bbernays Awaiting requested review from bbernays

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zagronitay @yevgenypats @bbernays @roneli