This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(testing): Don't add ignored diagnostics to errors validation (#283)
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 #### Summary Related to cloudquery/cq-provider-gcp#267. The tests on cloudquery/cq-provider-gcp#267 are failing since we validate ignored errors. Relevant SDK code is https://github.com/cloudquery/cq-provider-sdk/blob/849cad30f6c3b335981822f19fdf275f6091df03/provider/execution/execution.go#L412 --- Use the following steps to ensure your PR is ready to be reviewed - [x] Read the [contribution guidelines](../blob/main/.github/CONTRIBUTING.md) 🧑🎓 - [x] Run `go fmt` to format your code 🖊 - [x] Lint your changes via `golangci-lint run --new-from-rev main` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [x] Update or add tests 🧪 - [x] Ensure the status checks below are successful ✅
- Loading branch information