update validation of exec err (#125)

* update validation of exec err
cloudquery · Dec 9, 2021 · c7d150c · c7d150c
1 parent be1cd34
commit c7d150c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [v0.5.4] - 2021-12-09
+
+### :spider: Fixed
+* fixed bad execution error validation [#125](https://github.com/cloudquery/cq-provider-sdk/pull/125)
+
 ## [v0.5.3] - 2021-12-06
 
 ### :gear: Changed

diff --git a/provider/provider.go b/provider/provider.go
@@ -3,6 +3,7 @@ package provider
 import (
 	"context"
 	"embed"
+	"errors"
 	"fmt"
 	"sync"
 	"sync/atomic"
@@ -244,6 +245,11 @@ func (p *Provider) collectExecutionDiagnostics(client schema.ClientMeta, exec sc
 	p.Logger.Debug("collecting diagnostics for resource execution", "resource", exec.ResourceName)
 	diagnostics := make(diag.Diagnostics, 0)
 	for _, e := range exec.PartialFetchFailureResult {
+		var execErr *diag.ExecutionError
+		if errors.As(e.Err, &execErr) {
+			diagnostics = append(diagnostics, execErr)
+			continue
+		}
 		if d, ok := e.Err.(diag.Diagnostic); ok {
 			diagnostics = append(diagnostics, d)
 			continue