You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
The default option was added to allow if an error occurs / the getter gets a nil to set a default value
The logic in execution is a little weird as with the funk.Get if nil is returned it will set default value (if not nil), but if a resolver is set
a default will only be set if the resolver returned an error, and in some cases like PathResolver it will act the same as funk.Get and return nil
Expected Behavior
default value should always be set / removed
Steps to Reproduce
Possible Solution
remove default option from schema.Table and use schema.PathResolverWithDefault / let resolvers define defaults or accept defaults as arguments.
Before removing the default value, we can first add the schema.PathResolverWithDefault as a starter.
Another option is to define the expected logic of when a default should be set
Provider and CloudQuery version
all
Additional Context
No response
The text was updated successfully, but these errors were encountered:
Describe the bug
The default option was added to allow if an error occurs / the getter gets a nil to set a default value
The logic in execution is a little weird as with the funk.Get if nil is returned it will set default value (if not nil), but if a resolver is set
a default will only be set if the resolver returned an error, and in some cases like PathResolver it will act the same as funk.Get and return nil
Expected Behavior
default value should always be set / removed
Steps to Reproduce
Possible Solution
remove default option from schema.Table and use schema.PathResolverWithDefault / let resolvers define defaults or accept defaults as arguments.
Before removing the default value, we can first add the schema.PathResolverWithDefault as a starter.
Another option is to define the expected logic of when a default should be set
Provider and CloudQuery version
all
Additional Context
No response
The text was updated successfully, but these errors were encountered: