Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Add Warning About File Descriptor Usage #126

Merged
merged 9 commits into from
Dec 13, 2021
Merged

Add Warning About File Descriptor Usage #126

merged 9 commits into from
Dec 13, 2021

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Dec 9, 2021

@bbernays bbernays changed the title Add Warning About File Descriptor Add Warning About File Descriptor Usage Dec 9, 2021
roneli
roneli suggested changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but we can improve this by returning a Diagnostic to the user.

provider/schema/execution.go Outdated Show resolved Hide resolved
@bbernays bbernays requested a review from roneli December 13, 2021 15:08
roneli
roneli approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpicks

provider/schema/execution.go Outdated Show resolved Hide resolved
provider/schema/execution.go Outdated Show resolved Hide resolved
@roneli roneli merged commit e827e07 into cloudquery:main Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yevgenypats yevgenypats yevgenypats approved these changes

@roneli roneli roneli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If open files limit reached show a message suggesting a solution
3 participants
@bbernays @yevgenypats @roneli