This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanenk
reviewed
Dec 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good idea. We need to think about right organization of resources to ease targets configuration. target
argument uses specific resource or module so we need to move all files to separate modules and use module names as parameters or we can try to list all the resources from provided files and pass them as a targets. I like the case with modules more.
yevgenypats
changed the title
Remove copying terraform directories and use terraform -target
snapshot testing sdk
Dec 28, 2021
amanenk
reviewed
Dec 28, 2021
This was referenced Dec 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still wip and I suggest merging this after our tests are back to green so I can validate this doesn't ruin anything.
Basically it remove a lot of complex logic and instead of copying the necessary terraform files for every single test just use
-target
https://learn.hashicorp.com/tutorials/terraform/resource-targeting?in=terraform/cliThis should make the tests more robust and it's preliminary to other improvements (like snapshot testing) we want to make in the future to make our tests more developer friendly and robust.