Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

snapshot testing sdk #137

Merged
merged 16 commits into from
Dec 29, 2021
Merged

snapshot testing sdk #137

merged 16 commits into from
Dec 29, 2021

Conversation

yevgenypats
Copy link
Member

This is still wip and I suggest merging this after our tests are back to green so I can validate this doesn't ruin anything.

Basically it remove a lot of complex logic and instead of copying the necessary terraform files for every single test just use -target https://learn.hashicorp.com/tutorials/terraform/resource-targeting?in=terraform/cli

This should make the tests more robust and it's preliminary to other improvements (like snapshot testing) we want to make in the future to make our tests more developer friendly and robust.

@yevgenypats yevgenypats added the enhancement New feature or request label Dec 22, 2021
Copy link
Contributor

@amanenk amanenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good idea. We need to think about right organization of resources to ease targets configuration. target argument uses specific resource or module so we need to move all files to separate modules and use module names as parameters or we can try to list all the resources from provided files and pass them as a targets. I like the case with modules more.

@yevgenypats yevgenypats changed the title Remove copying terraform directories and use terraform -target snapshot testing sdk Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants