Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

feat: Testing: Require cq_fetch_date on every tsdb table #195

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

disq
Copy link
Member

@disq disq commented Feb 28, 2022

No description provided.

Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'd add more docs as not sure what is the purpose of the query and what exactly it is checking.

"github.com/spf13/afero"
"github.com/stretchr/testify/assert"
)

const queryPrimaryKeys = `SELECT kcu.table_name, c.constraint_name, ARRAY_AGG(kcu.column_name::text ORDER BY kcu.ordinal_position) AS pk_cols
FROM information_schema.table_constraints c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a bit of docs on what this query is doing ? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"documented"

@disq
Copy link
Member Author

disq commented Feb 28, 2022

also, the test name (and the fn that runs the test) is self-documenting with the names.

@disq disq merged commit 492bdac into main Feb 28, 2022
@disq disq deleted the feat/require_cqfetchdate branch February 28, 2022 10:14
disq added a commit that referenced this pull request Feb 28, 2022
kodiakhq bot pushed a commit that referenced this pull request Jun 20, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/hashicorp/go-plugin](https://togithub.com/hashicorp/go-plugin) | require | patch | `v1.4.3` -> `v1.4.4` |

---

### Release Notes

<details>
<summary>hashicorp/go-plugin</summary>

### [`v1.4.4`](https://togithub.com/hashicorp/go-plugin/blob/HEAD/CHANGELOG.md#v144)

[Compare Source](https://togithub.com/hashicorp/go-plugin/compare/v1.4.3...v1.4.4)

ENHANCEMENTS:

-   client: increase level of plugin exit logs \[[GH-195](https://togithub.com/hashicorp/go-plugin/pull/195)]

BUG FIXES:

-   Bidirectional communication: fix bidirectional communication when AutoMTLS is enabled \[[GH-193](https://togithub.com/hashicorp/go-plugin/pull/193)]
-   RPC: Trim a spurious log message for plugins using RPC \[[GH-186](https://togithub.com/hashicorp/go-plugin/pull/186)]

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants