This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Testing: Require cq_fetch_date on every tsdb table #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I'd add more docs as not sure what is the purpose of the query and what exactly it is checking.
"github.com/spf13/afero" | ||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
const queryPrimaryKeys = `SELECT kcu.table_name, c.constraint_name, ARRAY_AGG(kcu.column_name::text ORDER BY kcu.ordinal_position) AS pk_cols | ||
FROM information_schema.table_constraints c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a bit of docs on what this query is doing ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"documented"
also, the test name (and the fn that runs the test) is self-documenting with the names. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 20, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hashicorp/go-plugin](https://togithub.com/hashicorp/go-plugin) | require | patch | `v1.4.3` -> `v1.4.4` | --- ### Release Notes <details> <summary>hashicorp/go-plugin</summary> ### [`v1.4.4`](https://togithub.com/hashicorp/go-plugin/blob/HEAD/CHANGELOG.md#v144) [Compare Source](https://togithub.com/hashicorp/go-plugin/compare/v1.4.3...v1.4.4) ENHANCEMENTS: - client: increase level of plugin exit logs \[[GH-195](https://togithub.com/hashicorp/go-plugin/pull/195)] BUG FIXES: - Bidirectional communication: fix bidirectional communication when AutoMTLS is enabled \[[GH-193](https://togithub.com/hashicorp/go-plugin/pull/193)] - RPC: Trim a spurious log message for plugins using RPC \[[GH-186](https://togithub.com/hashicorp/go-plugin/pull/186)] </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.