This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
feat: Return full rlimit #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
reviewed
May 31, 2022
Comment on lines
+20
to
+26
| if err != nil || ulimit.Max == 0 { | ||
| return limit | ||
| } | ||
| if ulimit > limit { | ||
| if ulimit.Max > limit { | ||
| return limit | ||
| } | ||
| return ulimit | ||
| return ulimit.Max |
There was a problem hiding this comment.
On a seperate/ related note, instead of going all the way up to the ulimit why not do something like ulimit * 0.8 So then we don't try and take all of the descriptors because we know there are other things that use file descriptors other than our go routines
There was a problem hiding this comment.
We can do that, will do in a separate pr
erezrokah
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
Related to https://github.com/cloudquery/cloudquery-issues/issues/372 returns full access to rlimit info on process
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)