-
Notifications
You must be signed in to change notification settings - Fork 15
feat!: IgnoreError Recursively for tables and columns #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let others reviews comment too, but WDYT about starting with the table level changes, and then moving to the column level changes?
be46ca5
to
4c262a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add two more comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 @yevgenypats please squash merge with a commit title prefix of feat!:
as this is a breaking change
@erezrokah will do! Will wait on @disq approval (regarding comment) and will squash merge 🚀 |
50a47be
to
8622c31
Compare
8622c31
to
a2b1816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
This adds recursive logic for both columns and tables so we dont have to put it in every column and relation.
This need more tests but ready for initial review.
Closes #323
Use the following steps to ensure your PR is ready to be reviewed
go fmt
to format your code 🖊golangci-lint run
🚨 (install golangci-lint here)