-
Notifications
You must be signed in to change notification settings - Fork 15
feat!: Support both YAML and HCL config #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, didn't approve as this is a draft, added some of my thoughts, tell me what you think :)
6bfb801
to
7949b66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, obviously not finished, but didn't have much comments one nit. yaml.Node is a great solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. just had one question/clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no further comments :)
a3654e7
to
0dcdd27
Compare
|
This way it's possible to maintain comments coming in from the provider.Example()
This reverts commit 10cf9e9.
to go with cloudquery/cq-provider-sdk#332 and cloudquery/cloudquery#887 `go run main.go init azure --config config.yml` creates this: ```yaml cloudquery: providers: - name: azure version: latest connection: type: postgres username: postgres password: pass host: localhost port: 5432 database: postgres sslmode: disable providers: # provider configurations - name: azure # Optional. if you not specified, cloudquery tries to access all subscriptions available to tenant # subscriptions: # - <YOUR_SUBSCRIPTION_ID_HERE> # # list of resources to fetch resources: - account.locations - authorization.role_assignments #... ```
No description provided.