This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
fix: Issues when PG username is 'cloudquery' #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, cloudquery misbehaved when the PG username was named 'cloudquery'. It created tables in the 'cloudquery' schema instead of the 'public' schema. This happened because the search path was '"$user", public', which means it depended on the username. This fix, upon connection to PG, will change serach_path to 'public' only, i.e. not dependent on username (which is way more predictable). This won't impact us explicitly accessing the 'cloudquery' schema via 'cloudquery.<table-name>', which is what we do when we actually need the 'cloudquery' schema.
yevgenypats
approved these changes
Jun 24, 2022
|
Made sure :) |
This was referenced Jun 29, 2022
Closed
Closed
This was referenced Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, cloudquery misbehaved when the PG username was named 'cloudquery'.
It created tables in the 'cloudquery' schema instead of the 'public' schema.
This happened because the search path was '"$user", public', which means it depended on the username.
This fix, upon connection to PG, will change serach_path to 'public' only, i.e. not dependent on username (which is way more predictable).
This won't impact us explicitly accessing the 'cloudquery' schema via 'cloudquery.', which is what we do when we actually need the 'cloudquery' schema.
closes: cloudquery/cloudquery#901.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)