Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

chore!: Remove unused code/features: Global tables, CascadeDeleteFilters, ExtraFields, AlwaysDelete #392

Merged
merged 6 commits into from
Jun 30, 2022

Conversation

disq
Copy link
Member

@disq disq commented Jun 28, 2022

Completes #308

#273 #309 #310 #311

@disq disq requested a review from a team as a code owner June 28, 2022 09:23
@disq disq requested review from hermanschaaf, roneli and bbernays and removed request for a team June 28, 2022 09:23
@disq disq changed the title chore!: Remove unused code chore!: Remove unused code/features: Global tables, CascadeDeleteFilters, ExtraFields, AlwaysDelete Jun 28, 2022
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love code deletion!

Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had two comments. The second is stating the obvious ^^, so just auto-resolve after reading it.

cqproto/internal/plugin.proto Show resolved Hide resolved
provider/schema/table.go Show resolved Hide resolved
@disq disq merged commit eee8029 into main Jun 30, 2022
@disq disq deleted the chore/remove-unused-code branch June 30, 2022 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants