Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

fix: Remove dead code #419

Merged
merged 2 commits into from
Jul 13, 2022
Merged

fix: Remove dead code #419

merged 2 commits into from
Jul 13, 2022

Commits on Jul 13, 2022

  1. fix: Remove dead code (default error classifier) 

    The code inside the defaultErrorClassifier was never actually executed, because it was always passed a 'diag', but the first line in defaultErrorClassifier was "if err type is diag, return nil".

In any case, it's definitely better not to classify a single error twice. A more reasonable implementation might be to 'fall back to default classifier, if specific classifier returned nil', but for now, let's just remove it.
    @shimonp21
    shimonp21 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    3c42dc5 View commit details
    Browse the repository at this point in the history

  2. test: Remove stale code

    @shimonp21
    shimonp21 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c3f48ef View commit details
    Browse the repository at this point in the history