feat: Expose max_row_group_length option for Parquet writer
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
Nov 6, 2024
| @@ -9,13 +9,16 @@ import ( | |||
| "github.com/invopop/jsonschema" | |||
| ) | |||
|
|
|||
| const defaultMaxRowGroupLength = 128 * 1024 * 1024 | |||
There was a problem hiding this comment.
For some reason this was set to 128 mibi rows but it's actually a row count.
marianogappa
approved these changes
Nov 6, 2024
| @@ -94,5 +115,8 @@ func (s *ParquetSpec) Validate() error { | |||
| if !slices.Contains(allowedRootRepetitions, s.RootRepetition) { | |||
| return fmt.Errorf("invalid rootRepetition: %s. Allowed values are %s", s.RootRepetition, strings.Join(allowedRootRepetitions, ", ")) | |||
| } | |||
| if s.MaxRowGroupLength != nil && *s.MaxRowGroupLength <= 0 { | |||
| return fmt.Errorf("invalid: maxRowGroupLength: %v. Must be zero or positive", *s.MaxRowGroupLength) | |||
There was a problem hiding this comment.
Zero would be going back to the default of the arrow parquetwriter. Updated this check to be < 0
erezrokah
reviewed
Nov 7, 2024
kodiakhq
bot
deleted the
feat/expose-parquet-max-row-group-length-option
branch
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
🤖 I have created a release *beep* *boop* --- ## [4.5.0](v4.4.0...v4.5.0) (2024-11-07) ### Features * Expose `max_row_group_length` option for Parquet writer ([#589](#589)) ([4a4b389](4a4b389)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.65.0 ([#581](#581)) ([136b836](136b836)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.66.0 ([#582](#582)) ([5ca0a10](5ca0a10)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.66.1 ([#583](#583)) ([69a6156](69a6156)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.67.0 ([#584](#584)) ([cab4c19](cab4c19)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.67.1 ([#585](#585)) ([d590743](d590743)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.68.0 ([#586](#586)) ([b19c239](b19c239)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.68.1 ([#587](#587)) ([3b9f708](3b9f708)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.68.2 ([#588](#588)) ([f2be0a6](f2be0a6)) * Optimized CSV writing ([#579](#579)) ([d688971](d688971)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Nov 8, 2024
#### Summary The support for setting the group length was added in #19578 implicitly via cloudquery/filetypes#589. This PR adds documentation for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.