-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: adding a resolver transformer (#43)
Adding the default implementation for the `ResolverTransformer` to set the value of a scalar based on a path lookup in the base resource item. fixes: #32
- Loading branch information
Showing
8 changed files
with
119 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
package io.cloudquery.schema; | ||
|
||
public class ClientMeta { | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package io.cloudquery.schema; | ||
|
||
import lombok.Builder; | ||
import lombok.Getter; | ||
|
||
@Builder | ||
@Getter | ||
public class Column { | ||
private String name; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package io.cloudquery.schema; | ||
|
||
import io.cloudquery.transformers.TransformerException; | ||
|
||
public interface ColumnResolver { | ||
void resolve(ClientMeta meta, Resource resource, Column column) throws TransformerException; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package io.cloudquery.schema; | ||
|
||
import lombok.Builder; | ||
import lombok.Getter; | ||
|
||
@Builder | ||
@Getter | ||
public class Resource { | ||
private Object item; | ||
|
||
|
||
public void set(String columnName, Object value) { | ||
} | ||
} |
24 changes: 24 additions & 0 deletions
24
lib/src/main/java/io/cloudquery/transformers/ResolverTransformer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package io.cloudquery.transformers; | ||
|
||
import io.cloudquery.helper.ReflectionPathResolver; | ||
import io.cloudquery.helper.ReflectionPathResolver.PathResolverException; | ||
import io.cloudquery.schema.ColumnResolver; | ||
|
||
import java.lang.reflect.Field; | ||
|
||
public interface ResolverTransformer { | ||
class DefaulResolverTransformer implements ResolverTransformer { | ||
@Override | ||
public ColumnResolver transform(Field field, String path) throws TransformerException { | ||
return (meta, resource, column) -> { | ||
try { | ||
resource.set(column.getName(), ReflectionPathResolver.resolve(resource.getItem(), path)); | ||
} catch (PathResolverException ex) { | ||
throw new TransformerException("Failed to resolve path: " + path, ex); | ||
} | ||
}; | ||
} | ||
} | ||
|
||
ColumnResolver transform(Field field, String path) throws TransformerException; | ||
} |
6 changes: 5 additions & 1 deletion
6
lib/src/main/java/io/cloudquery/transformers/TransformerException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
package io.cloudquery.transformers; | ||
|
||
public class TransformerException extends Exception{ | ||
public class TransformerException extends Exception { | ||
public TransformerException(String message) { | ||
super(message); | ||
} | ||
|
||
public TransformerException(String message, Throwable ex) { | ||
super(message, ex); | ||
} | ||
} |
53 changes: 53 additions & 0 deletions
53
lib/src/test/java/io/cloudquery/transformers/DefaultResolverTransformerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
package io.cloudquery.transformers; | ||
|
||
import io.cloudquery.schema.Column; | ||
import io.cloudquery.schema.Resource; | ||
import io.cloudquery.transformers.ResolverTransformer.DefaulResolverTransformer; | ||
import lombok.Builder; | ||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.ExtendWith; | ||
import org.mockito.Mock; | ||
import org.mockito.junit.jupiter.MockitoExtension; | ||
|
||
import static org.junit.Assert.assertThrows; | ||
import static org.mockito.ArgumentMatchers.eq; | ||
import static org.mockito.Mockito.verify; | ||
import static org.mockito.Mockito.when; | ||
|
||
@ExtendWith(MockitoExtension.class) | ||
class DefaultResolverTransformerTest { | ||
|
||
@Builder | ||
public static class ResourceItem { | ||
public String myCustomID; | ||
} | ||
|
||
private DefaulResolverTransformer transformer; | ||
|
||
@Mock | ||
private Resource resource; | ||
|
||
@BeforeEach | ||
void setUp() { | ||
transformer = new DefaulResolverTransformer(); | ||
|
||
when(resource.getItem()).thenReturn(ResourceItem.builder().myCustomID("1234").build()); | ||
} | ||
|
||
@Test | ||
public void shouldTransformCustomFieldNamesFromResource() throws TransformerException { | ||
Column targetColumn = Column.builder().name("id").build(); | ||
|
||
transformer.transform(null, "myCustomID").resolve(null, resource, targetColumn); | ||
|
||
verify(resource).set(eq("id"), eq("1234")); | ||
} | ||
|
||
@Test | ||
public void shouldThrowExceptionIfResourceFieldNameNotFound() throws TransformerException { | ||
Column targetColumn = Column.builder().name("id").build(); | ||
|
||
assertThrows(TransformerException.class, () -> transformer.transform(null, "badFieldName").resolve(null, resource, targetColumn)); | ||
} | ||
} |