Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adapt to Gmail. #1949

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Fix: Adapt to Gmail. #1949

merged 1 commit into from
Feb 24, 2024

Conversation

liaosunny123
Copy link
Contributor

Add Message-ID to the mail service header to adapt to services such as Gmail

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2024

CLA assistant check
All committers have signed the CLA.

@HFO4
Copy link
Member

HFO4 commented Feb 23, 2024

Is there any document on why this field will affect Gmail?

@liaosunny123
Copy link
Contributor Author

liaosunny123 commented Feb 23, 2024

Is there any document on why this field will affect Gmail?

refer to https://datatracker.ietf.org/doc/html/rfc5322#section-3.6.4

Here:
Though listed as optional in the table in section 3.6, every message
SHOULD have a "Message-ID:" field. Furthermore, reply messages
SHOULD have "In-Reply-To:" and "References:" fields as appropriate
and as described below.

If you send email to Gmail with original settiings, you will got:
host gmail-smtp-in.l.google.com[xxx] said: 550-5.7.1 [xxx] Messages missing a valid Message-ID header are not accepted. For more information, go to https://support.google.com/mail/?p=RfcMessageNonCompliant and review RFC 5322 specifications.

@HFO4 HFO4 merged commit 3edb00a into cloudreve:master Feb 24, 2024
1 check passed
@HFO4
Copy link
Member

HFO4 commented Feb 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants