bugfix: convert metainfo from http style to rpc style #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous codes, metainfo does not have a uniform style, and it cannot work properly between different types of service. We agree to use following rules: - For RPC, use uppercase letters and `_` as separators when transmitting - For HTTP, use lowercase letters and `-` as separators when transmitting - For both protocols, use RPC style (uppercase with `_`) for storing keys of metainfo. To implement this more elegantly, we defined a trait `Converter` and use it for converting the key names between transmitting format and storing format. Signed-off-by: Yu Li <[email protected]>
yukiiiteru
force-pushed
the
bugfix/http-metainfo
branch
from
5fe5423
to
8c9ac3b
Compare
Millione
approved these changes
Jun 19, 2024
PureWhiteWu
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In previous codes, metainfo does not have a uniform style, and it cannot work properly between different types of service.
Solution
We agree to use following rules:
_as separators when transmitting-as separators when transmitting_) for storing keys of metainfo.To implement this more elegantly, we defined a trait
Converterand use it for converting the key names between transmitting format and storing format.Unit tests are also updated.